Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Package maintainer guide to Core maintainer guide. (backport #4619) #4644

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 20, 2024

This rename is motivated by a desire to begin a manual / guide for maintainers of community packages in ROS 2 distributions.

The current title is overly broad, as the guide content is targeted at ROS 2 core package maintainers rather than a maintainer of any package released in ROS 2.

Renaming and redirecting articles has a cost and I know this rename isn't free. But I think it's justified in order to provide space for content aimed at community maintainers.

There's an additional commit on here of edits I made to the doc while squaring it up with its new title. Even if we don't take the rename some of those edits are worth keeping in a dedicated PR.

Most of the changes there are clarifying whether an operation is per-repository or per-package. I've gone through and updated the documentation to use "package" or "repository" when correct in context. In a couple of cases, I removed the specification entirely (particularly in front of the word "maintainer").


This is an automatic backport of pull request #4619 done by Mergify.

* Use package and repository appropriately in context.

ROS 2 source repositories may consist of multiple packages and certain
operations are per-repository rather than per-package. I've gone through
and updated the documentation to use "package" or "repository" when
correct in context. In a couple of cases, I removed the specification
entirely (particularly in front of the word "maintainer").

* Rename "Package maintainer guide" to "Core maintainer guide".

This rename is motivated by a desire to begin a manual / guide for
maintainers of _community_ packages in ROS 2 distributions.

The current title is overly broad, as the guide content is targeted at
ROS 2 core package maintainers rather than a maintainer of any package
released in ROS 2.

Renaming and redirecting articles has a cost and I know this rename
isn't free. But I think it's justified in order to provide space for
content aimed at community maintainers.

* Move renamed guide.

(cherry picked from commit 2f80c3f)
Copy link

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/10478524426/artifacts/1834355742.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-4644/index.html in your favorite browser

@clalancette clalancette merged commit c8247bb into iron Aug 20, 2024
4 checks passed
@clalancette clalancette deleted the mergify/bp/iron/pr-4619 branch August 20, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants